Work-in-progress Git FS plugin

Plugins
1

Hello!

Inspired by the s3 VFS plugin, I’ve started an attempt to make a Git VFS plugin.

Why not just serve the worktree? I’m looking to use this to serve Forgejo/Gitea git repositories on the same VPS, and so there is no worktree. My aim is to be able to make serving a self-hosted site from a self-hosted repo as easy as:

file_server {
    fs git {
        repository /var/lib/gitea/repositories/user/site.git
        revision html
    }
}

I think it’s mostly there, but this is the first thing I’ve tried doing in Go. For some reason it seems that the configuration parameters aren’t being loaded into the FS struct :confused:.

If I can encourage anybody else to take a look at this and help, that would be great!

Update: It works now :smiley:

2

I’ve added some more debug statements. It looks like the parameters are being loaded correctly … then discarded??

INFO    using provided configuration    {"config_file": "/tmp/Caddyfile", "config_adapter": ""}
INFO    caddy.fs.git    thinking about    {"arg": "repository"}
INFO    caddy.fs.git    seen 'repository' arg
INFO    caddy.fs.git    new value    {"repository": "/tmp/testrepo"}
INFO    caddy.fs.git    thinking about    {"arg": "revision"}
INFO    caddy.fs.git    seen 'revision' arg
INFO    caddy.fs.git    new value    {"revision": "HEAD"}
INFO    admin    admin endpoint started    {"address": "localhost:2019", "enforce_origin": false, "origins": ["//localhost:2019", "//[::1]:2019", "//127.0.0.1:2019"]}
WARN    http.auto_https    automatic HTTPS is completely disabled for server    {"server_name": "srv0"}
INFO    caddy.fs.git    Parsed repository path    {"repository": ""}
INFO    caddy.fs.git    Parsed revision path    {"revision": ""}
ERROR    caddy.fs.git    Repository is unset
3

I cannot replicate the erasure you’re seeing. The values are retained and the plugin “works” (panics due to missing interface implementation). How are you running it?

4

Ah, I’ve recently worked out (and pushed fixes) that was due to the case of some fields in the FS struct.

Now listing directories seems to work well, but file access doesn’t: I’m guessing Caddy needs a few more methods that aren’t defined yet? I don’t actually see any panics my end though, just curl: (52) Empty reply from server.

5

Ah, I see this gives a list of what Caddy requires:

At the least, I see that GitHub - thediveo/gitrepofs: A Go fs.FS git repository file system to easily access a repository at a specific tag (or other git reference). doesn’t implement the io.Seeker interface. I wonder how hard that would be to monkeypatch on :thinking:

6

I think I’ve worked out an approach for the seekable problem: since it looks like go-git’s object reader is non-seekable, read the entire object into a bytes.Reader, and then from that define a fs.File type that is seekable.

7

Hey, this now seems to be completely working! :party:

2 Likes
8

This topic was automatically closed after 30 days. New replies are no longer allowed.