CutterXYZ
(Cutter Xyz)
April 27, 2023, 1:20pm
1
Hi!
Is it possible to let the user download his selection of files as an archive ?
Thanks.
matt
(Matt Holt)
April 27, 2023, 3:20pm
2
We’ve had this request before but ultimately rejected it in the standard distribution:
caddyserver:master
← jaysonsantos:download-zip
opened 08:48PM - 23 Oct 19 UTC
<!--
Thank you for contributing to Caddy! Please fill this out to help us make … the most of your pull request.
Was this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.
It is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.
-->
## 1. What does this change do, exactly?
For now this only changes browse's template to include a link to download folders as zip files.
## 2. Please link to the relevant issues.
https://github.com/caddyserver/caddy/issues/2829
## 3. Which documentation changes (if any) need to be made because of this PR?
I would say tha this feature should be optional, if it is an accepted idea that should for sure be documented
## 4. Checklist
I would like to hear from you before writing tests as I am not experienced in go development
- [ ] I have written tests and verified that they fail without my change
- [x] I have squashed any insignificant commits
- [x] This change has comments explaining package types, values, functions, and non-obvious lines of code
- [x] I am willing to help maintain this change if there are issues with it later
## 5. Missing points
- [ ] Use accept header for negotiation
- [ ] Create svg icons
- [ ] Respect hidden files and avoid shallow download?
This would make a great plugin I think, but it would also lead to higher CPU and memory use on the server. It was too risky for us to accept at the time (esp. when v2 was barely being released).
system
(system)
Closed
May 27, 2023, 3:20pm
3
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.