Browse plugin needs an update (maybe)

Plugins
1

Hello,

the least we can say is that I am not a github expert; also, I allow myself to make the following suggestion here.

In my eyes, the function `“isSymlinkTargetDir()”
of “browse.go” has not yet been updated on the official caddy github at
‘caddyserver/caddy/caddyhttp/browse.go’.

I have found what I think is a more or less valid version in :
https://github.com/reds/caddy/commit/6b8e40b3fb4553142aa514fbfd3b0a5ce805fd1
which was committed and verified 2 years ago.

I hope I do not make mistakes; if not, I apologize.
Hope to help.

2

I believe it (or equivalent) made it in with browse: Show symbolic links and target's type properly by cez81 · Pull Request #1667 · caddyserver/caddy · GitHub

3

Thanks for the reply.

I have seen the ‘1667’ commit : well done for the template.

I believed that this line :
target, err := config.Fs.Root.Open(path.Join(urlPath, f.Name()))
pointed to the link itself, not to the file or dir pointed to. ==> I made a mistake !

In reality, you give a try to the symlink trying to open it inside the jailed FileSystem
(but the linked file or dir could be located outside ?).

Using “os.Readlink(f.Name())” and “…os.Lstat(target)” should be another way,
Less safe ? Faster ? Maybe not.

Thank you very much ; my excuse: it’s not so simple.

4

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.